[Select][base] Fix flicker on click of controlled Select button#37855
Merged
mnajdova merged 6 commits intomui:masterfrom Aug 7, 2023
Merged
[Select][base] Fix flicker on click of controlled Select button#37855mnajdova merged 6 commits intomui:masterfrom
mnajdova merged 6 commits intomui:masterfrom
Conversation
Netlify deploy previewhttps://deploy-preview-37855--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
oliviertassinari
added
scope: select
Contributor
Author
|
Hi @michaldudak , just wanted to check in and see if you've gotten a chance to take a look at this PR yet? |
michaldudak
reviewed
Jul 19, 2023
Member
michaldudak
left a comment
michaldudak
left a comment
There was a problem hiding this comment.
Thanks for investigating and fixing this. Your fix actually brings it closer in functionality to native <select>, so 👍
michaldudak
changed the title
michaldudak
approved these changes
Jul 20, 2023
Member
michaldudak
left a comment
michaldudak
left a comment
There was a problem hiding this comment.
Looks great! Thank you for working on this!
richbustos
pushed a commit
that referenced
this pull request
Aug 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cause of the issue was that the state of the Select component was only updated onClick. However, the highlighting of the button was based on onMouseDown and onMouseUp. Since onMouseUp is triggered before onClick, there was a moment of time between the onMouseUp and onClick events which created the flicker. I solved this by updating the state of the component during the onMouseDown event. This does slightly change the functionality of the component, I'm not sure if this is an ok change or not, please lmk!
Closes #37673