Skip to content

[typescript][system] Rename one letter type parameters in type maps and props#38170

Merged
michaldudak merged 3 commits intomui:masterfrom
michaldudak:type-params-system
Aug 3, 2023
Merged

[typescript][system] Rename one letter type parameters in type maps and props#38170
michaldudak merged 3 commits intomui:masterfrom
michaldudak:type-params-system

Conversation

@michaldudak
Copy link
Copy Markdown
Member

Similarly to #38155, in this PR I renamed one-letter type parameters in System's type maps and props to something more meaningful.

@michaldudak michaldudak added typescript scope: system The system, the design tokens / styling foundations used across components. eg. @mui/system with MUI labels Jul 26, 2023
@michaldudak michaldudak requested a review from siriwatknp July 26, 2023 14:25
Copy link
Copy Markdown
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it ❤️

@mui-bot
Copy link
Copy Markdown

mui-bot commented Jul 26, 2023

Netlify deploy preview

https://deploy-preview-38170--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against c7369a4

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jul 27, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jul 27, 2023
@michaldudak michaldudak requested a review from brijeshb42 August 3, 2023 07:25
Copy link
Copy Markdown
Contributor

@brijeshb42 brijeshb42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaldudak michaldudak merged commit 71ae440 into mui:master Aug 3, 2023
@michaldudak michaldudak deleted the type-params-system branch August 3, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: system The system, the design tokens / styling foundations used across components. eg. @mui/system with MUI typescript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants