[SelectField] Add callback signatures to docs; improve other props.#3924
Merged
oliviertassinari merged 1 commit intomui:masterfrom May 6, 2016
theosherry:SelectField_docs
Merged
[SelectField] Add callback signatures to docs; improve other props.#3924oliviertassinari merged 1 commit intomui:masterfrom theosherry:SelectField_docs
oliviertassinari merged 1 commit intomui:masterfrom
theosherry:SelectField_docs
Conversation
37 tasks
| * If true, the width will automatically be set according to the | ||
| * items inside the menu. | ||
| * To control this width in css instead, leave this prop to `false`. | ||
| * To control the width in CSS instead, leave this prop to `false`. |
Member
There was a problem hiding this comment.
'leave this prop set to false'?
Member
|
Thanks @theosherry - sorry for the delay in reviewing, I've been away, and then tied up with work. Looks good apart from one possible clarification. |
mbrookes
added
PR: Needs Revision
docs
Contributor
Author
|
@mbrookes No problem 😄 |
Member
|
Thanks. 👍 |
Member
|
@theosherry great PR regarding the docs, as always 👍. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, the next one for #3096.