Skip to content

Comments

[Select] Fix auto width cropping#45625

Closed
yermartee wants to merge 5 commits intomui:masterfrom
yermartee:fix/select-auto-width-cropping
Closed

[Select] Fix auto width cropping#45625
yermartee wants to merge 5 commits intomui:masterfrom
yermartee:fix/select-auto-width-cropping

Conversation

@yermartee
Copy link
Contributor

Fixes #45276

@mui-bot
Copy link

mui-bot commented Mar 19, 2025

Netlify deploy preview

https://deploy-preview-45625--material-ui.netlify.app/

@material-ui/core: parsed: +0.04% , gzip: +0.07%
TextField: parsed: +0.16% , gzip: +0.21%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against d685405

@TheOneTheOnlyJJ
Copy link

I'm wondering if there should be a prop that controls this behavior, what do you think?

@yermartee
Copy link
Contributor Author

Good question @TheOneTheOnlyJJ , I think it should be controlled by a prop to avoid breaking changes in existing components. For now, I’m unable to focus on this issue, but I will try to finalize the solution.

I'm wondering if there should be a prop that controls this behavior, what do you think?

@aarongarciah aarongarciah changed the title [Select] Fix/select auto width cropping [Select] Fix auto width cropping Mar 24, 2025
@aarongarciah aarongarciah added scope: select Changes related to the select. package: material-ui labels Mar 24, 2025
@aarongarciah
Copy link
Member

@yermartee do you plan to work on this in the short term? If not, let's close it. You can always re-open it.

@yermartee
Copy link
Contributor Author

Yes @aarongarciah Good idea! Right now, I’m focused on my full-time job, so I don’t have time to make changes at the moment.

Could you please advise which name we should pick for the parameter that will handle the auto-width cropping issue?

@yermartee yermartee closed this Mar 24, 2025
@aarongarciah
Copy link
Member

@yermartee I think we shouldn't add a new prop for this. It should just take the width of the largest label or value when the prop autoWidth is true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: select Changes related to the select.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants