-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
[docs] Fix Roboto font not loading in iframe demos #47660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Netlify deploy previewhttps://deploy-preview-47660--material-ui.netlify.app/ Bundle size report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR attempts to fix font loading issues in iframe demos by adding a srcDoc attribute with Google Fonts link for Roboto. The goal is to prevent demos from falling back to system fonts (Helvetica/Arial) when displayed in iframes.
Changes:
- Added
srcDocattribute to iframe elements in DemoSandbox.js with basic HTML structure - Included Google Fonts stylesheet link for Roboto font (weights 300, 400, 500, 700)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Noticed while working on #47635, demos were not using the correct fonts in iframes.
srcDocattribute to iframe demos with Google Fonts link for RobotoScreen.Recording.2026-01-21.at.11.25.11.mov