[code-infra] Setup workflow to auto publish internal packages#47952
[code-infra] Setup workflow to auto publish internal packages#47952brijeshb42 wants to merge 1 commit intomui:masterfrom
Conversation
brijeshb42
added
the
scope: code-infra
Netlify deploy previewhttps://deploy-preview-47952--material-ui.netlify.app/ Bundle size report
|
brijeshb42
force-pushed
the
canary-publish
branch
from
2fd2464 to
fd5cbe6
Compare
| pnpm code-infra publish-canary --package @mui/internal-markdown @mui/docs @mui/internal-scripts @mui-internal/api-docs-builder @mui/internal-docs-utils | ||
|
|
||
| publish: | ||
| if: github.event_name == 'workflow_dispatch' |
There was a problem hiding this comment.
What if we want to use workflow_dispatch to test the canary publishing?
There was a problem hiding this comment.
you mean for the new job publish-internal ? I can add the workflow_dispatch check there as well if desired. I don't see the need.
As soon as this PR gets merged, it'll trigger a publish anyways and can be tested there. And you cannot trigger manually from a branch anyways for testing.
I have explicitly kept workflow_dispatch check in the previous publish job since I also added the on.push.branches trigger.
There was a problem hiding this comment.
I believe with workflow_dispatch it's possible to test a change in a PR without merging first.
There was a problem hiding this comment.
Hmm. Seems for that this needs to exist first in the main branch then we can trigger for next PR. I'll add the check.
brijeshb42
force-pushed
the
canary-publish
branch
from
fd5cbe6 to
d24760e
Compare
brijeshb42
force-pushed
the
canary-publish
branch
from
d24760e to
7b45015
Compare
whenever a new commit lands in master.
brijeshb42
force-pushed
the
canary-publish
branch
from
7b45015 to
96c38da
Compare
3 participants
whenever a new commit lands in master.