[card] Remove deprecated CardHeader props by silviuaavram · Pull Request #47995 · mui/material-ui

silviuaavram · 2026-03-16T15:48:06Z

Try it here: https://stackblitz.com/edit/crdjeux1?file=src%2FDemo.tsx

I have followed (at least) the PR section of the contributing guide.

mui-bot · 2026-03-16T15:49:31Z

Netlify deploy preview

docs/data/material/migration/upgrade-to-v9/upgrade-to-v9.md

Bundle size report

Bundle	Parsed size	Gzip size
@mui/material	▼-75B^(-0.01%)	▼-7B^(0.00%)
@mui/lab	0B^(0.00%)	0B^(0.00%)
@mui/system	0B^(0.00%)	0B^(0.00%)
@mui/utils	0B^(0.00%)	0B^(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against e4564fd

Copilot

Pull request overview

Removes the deprecated CardHeader props (titleTypographyProps / subheaderTypographyProps) and updates the implementation, TypeScript types, type tests, and documentation to rely on slotProps instead (including adding an upgrade-to-v9 migration note).

Changes:

Removed deprecated props from CardHeader runtime implementation and PropTypes.
Removed deprecated props (and related generics) from CardHeader TypeScript definitions.
Updated type tests and API docs JSON, and added a v9 migration snippet/codemod pointer.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
packages/mui-material/src/CardHeader/CardHeader.spec.tsx	Replaces deprecated prop type tests with `slotProps`-based tests (currently has several missing `@ts-expect-error` annotations).
packages/mui-material/src/CardHeader/CardHeader.js	Removes deprecated prop handling and PropTypes entries (note: removed prop names may now leak via `...other`).
packages/mui-material/src/CardHeader/CardHeader.d.ts	Removes deprecated props and related generics from public TS types.
docs/translations/api-docs/card-header/card-header.json	Removes deprecated prop entries from translated API docs.
docs/pages/material-ui/api/card-header.json	Removes deprecated prop entries from the generated API docs page JSON.
docs/data/material/migration/upgrade-to-v9/upgrade-to-v9.md	Adds migration guidance and codemod command for the removed CardHeader props.

Comments suppressed due to low confidence (1)

packages/mui-material/src/CardHeader/CardHeader.js:88

After removing titleTypographyProps / subheaderTypographyProps from the destructuring, those props will now remain in ...other and end up being forwarded to the root slot (as unknown DOM attributes) if consumers still pass them. Consider explicitly destructuring and discarding these removed props (without supporting them) to avoid leaking them to the DOM and triggering React unknown-prop warnings.

  const {
    action,
    avatar,
    component = 'div',
    disableTypography = false,
    subheader: subheaderProp,
    title: titleProp,
    slots = {},
    slotProps = {},
    ...other
  } = props;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

packages/mui-material/src/CardHeader/CardHeader.spec.tsx

docs/data/material/migration/upgrade-to-v9/upgrade-to-v9.md

ZeeshanTamboli · 2026-03-18T08:29:14Z

packages/mui-material/src/CardHeader/CardHeader.d.ts

 export type CardHeaderProps<
  RootComponent extends React.ElementType = CardHeaderTypeMap['defaultComponent'],
  AdditionalProps = {},
-  TitleTypographyComponent extends React.ElementType = 'span',
-  SubheaderTypographyComponent extends React.ElementType = 'span',
-> = OverrideProps<
-  CardHeaderTypeMap<
-    AdditionalProps,
-    RootComponent,
-    TitleTypographyComponent,
-    SubheaderTypographyComponent
-  >,
-  RootComponent
->;


We should add this also in the migration guide that CardHeaderProps does not support these two generic parameters now (Use slotProps). Because CardHeaderProps is a public TS type.

ZeeshanTamboli · 2026-03-18T08:32:52Z

packages/mui-material/src/CardHeader/CardHeader.spec.tsx

-    // @ts-expect-error
-    titleTypographyProps: true,
+    slotProps: {
+      title: true,
+    },


How come title slot props support boolean?

From Claude Code:

Slot prop types resolve through SlotComponentProps to Partial<ComponentPropsWithRef<T>> & TOverrides. When TOverrides is an empty override interface like CardHeaderTitleSlotPropsOverrides (designed for module augmentation), the intersection simplifies to Partial<ComponentPropsWithRef<T>> — a type where every property is optional. In TS, primitives like true are assignable to any type where all properties are optional, because there are no required properties to violate.

The suggested fix is to add & object to

material-ui/packages/mui-utils/src/types/index.ts

Line 12 in 2301b2a

| (Partial<React.ComponentPropsWithRef<TSlotComponent>> & TOverrides)

so it becomes (Partial<React.ComponentPropsWithRef<TSlotComponent>> & TOverrides & object)

Unlike & any which destroys all type info, & object preserves autocomplete and property checking — it only adds "must be non-primitive." This is exactly what the object type was designed for. The fix is a 2-line change in SlotComponentProps and SlotComponentPropsWithSlotState in mui-utils.

Fix suggested can be considered.

Is this related to the migration PR? Or something extra we need to do? I'm OK adding it here but just wanted to make sure we're not extending scope that much.

Makes sense to do this change separately so it's easier to isolate if something backfires ~

This test should be removed? titleTypographyProps is not valid anymore.

packages/mui-material/src/CardHeader/CardHeader.spec.tsx

docs/data/material/migration/upgrade-to-v9/upgrade-to-v9.md

siriwatknp · 2026-03-17T09:37:40Z

packages/mui-material/src/CardHeader/CardHeader.spec.tsx

+      },
    }}
  />;
-  // @ts-expect-error


this should not be removed?

packages/mui-material/src/CardHeader/CardHeader.spec.tsx

siriwatknp · 2026-03-20T02:42:30Z

packages/mui-material/src/CardHeader/CardHeader.spec.tsx

-    // @ts-expect-error
-    titleTypographyProps: true,
+    slotProps: {
+      title: true,
+    },


This test should be removed? titleTypographyProps is not valid anymore.

packages/mui-material/src/CardHeader/CardHeader.d.ts

Copilot AI review requested due to automatic review settings March 16, 2026 15:48

silviuaavram added breaking change Introduces changes that are not backward compatible. scope: card Changes related to the card. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. v9.x labels Mar 16, 2026

Copilot started reviewing on behalf of silviuaavram March 16, 2026 15:48 View session

silviuaavram mentioned this pull request Mar 16, 2026

[material-ui] Remove deprecated props from all components #47987

Closed

49 tasks

silviuaavram requested review from ZeeshanTamboli and siriwatknp March 16, 2026 15:54

Copilot AI reviewed Mar 16, 2026

View reviewed changes

oliviertassinari changed the title ~~[cardheader] Remove deprecated props~~ [card] Remove deprecated CardHeader props Mar 17, 2026

ZeeshanTamboli reviewed Mar 17, 2026

View reviewed changes

docs/data/material/migration/upgrade-to-v9/upgrade-to-v9.md Outdated Show resolved Hide resolved

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 17, 2026

silviuaavram force-pushed the chore/remove-deprecated-props-6 branch from 36354a8 to 1398df1 Compare March 17, 2026 12:14

github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Mar 17, 2026

ZeeshanTamboli reviewed Mar 18, 2026

View reviewed changes

packages/mui-material/src/CardHeader/CardHeader.spec.tsx Show resolved Hide resolved

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 19, 2026

siriwatknp reviewed Mar 20, 2026

View reviewed changes

packages/mui-material/src/CardHeader/CardHeader.d.ts Show resolved Hide resolved

silviuaavram added 3 commits March 23, 2026 16:49

[cardheader] Remove deprecated props

e4660bb

upgrade guide

aae35a5

refactor type changes

b18d040

silviuaavram force-pushed the chore/remove-deprecated-props-6 branch from 1398df1 to b18d040 Compare March 23, 2026 15:13

remove the props

e4564fd

siriwatknp approved these changes Mar 24, 2026

View reviewed changes

silviuaavram merged commit 00a8186 into mui:master Mar 24, 2026
23 checks passed

silviuaavram deleted the chore/remove-deprecated-props-6 branch March 24, 2026 08:14

Uh oh!

Conversation

silviuaavram commented Mar 16, 2026 • edited by siriwatknp Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mui-bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Netlify deploy preview

Bundle size report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

silviuaavram commented Mar 16, 2026 •

edited by siriwatknp

Loading

mui-bot commented Mar 16, 2026 •

edited

Loading