[Slider] Remove deprecated props#47996
Merged
siriwatknp merged 10 commits intomui:masterfrom Mar 18, 2026
Merged
Conversation
42 tasks
Netlify deploy previewBundle size report
|
silviuaavram
approved these changes
Mar 17, 2026
| const MarkSlot = slots?.mark ?? components.Mark ?? SliderMark; | ||
| const MarkLabelSlot = slots?.markLabel ?? components.MarkLabel ?? SliderMarkLabel; | ||
| const InputSlot = slots?.input ?? components.Input ?? 'input'; | ||
| const RootSlot = slots?.root ?? SliderRoot; |
Member
There was a problem hiding this comment.
Really curious why in Slider we don't follow other components. Just pass elementType as the default one, then let the useSlot get what it needs from externalForwardedProps. Here we're manually getting the elementType, then the slotsProps, and then we pass them to useSlot.
I don't know which one is better, but from what I've seen in other components so far, we're letting useSlot handle all of this.
…cated-Slider-components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the deprecated
componentsandcomponentsPropsprops from the Slider component. Users should useslotsandslotPropsinstead.Breaking change
componentsprop removed → useslotscomponentsPropsprop removed → useslotPropsMigration:
Codemod:
Test plan
slots/slotProps)pnpm proptypes && pnpm docs:apiregenerated