[popover] Support visualViewport positioning#48288
Open
mj12albert wants to merge 2 commits intomui:masterfrom
Open
[popover] Support visualViewport positioning#48288mj12albert wants to merge 2 commits intomui:masterfrom
mj12albert wants to merge 2 commits intomui:masterfrom
Conversation
Bundle size
Deploy previewhttps://deploy-preview-48288--material-ui.netlify.app/ Check out the code infra dashboard for more information about this PR. |
mj12albert
force-pushed
the
popover-visual-viewport
branch
2 times, most recently
from
70865bf to
5fd68fc
Compare
mj12albert
added
scope: menu
mj12albert
requested review from
ZeeshanTamboli,
michelengelen,
silviuaavram and
siriwatknp
Member
ZeeshanTamboli
left a comment
ZeeshanTamboli
left a comment
There was a problem hiding this comment.
Initial review. Will review in detail later.
| return typeof anchorEl === 'function' ? anchorEl() : anchorEl; | ||
| } | ||
|
|
||
| function getAnchorWindow(anchorEl) { |
Member
There was a problem hiding this comment.
Would a better name be getAnchorElWindow?
|
|
||
| if (resolvedAnchorEl && resolvedAnchorEl.nodeType === 1) { | ||
| anchorElement = resolvedAnchorEl; | ||
| } else if (resolvedAnchorEl?.contextElement && resolvedAnchorEl.contextElement.nodeType === 1) { |
Member
There was a problem hiding this comment.
What is contextElement? I can't find anything about it.
Comment on lines
+236
to
+244
| // Convert the anchor rect to the popover's offsetParent. Some pinch-zoom paths | ||
| // report the fixed Modal root relative to the visual viewport. | ||
| const containerRect = element.offsetParent?.getBoundingClientRect(); | ||
| const containerTop = Math.min(containerRect?.top ?? 0, 0); | ||
| const containerLeft = Math.min(containerRect?.left ?? 0, 0); | ||
|
|
||
| // Calculate element positioning relative to the container. | ||
| let top = anchorOffset.top - containerTop - elemTransformOrigin.vertical; | ||
| let left = anchorOffset.left - containerLeft - elemTransformOrigin.horizontal; |
Member
There was a problem hiding this comment.
Can you explain what this all is doing compared to earlier calculation?
Member
Author
There was a problem hiding this comment.
Extracted this part to a getAnchorOffsetRelativeToContainer function and added comments there
anchorOffset is in viewport coordinates, popover paper is positioned inside its offsetParent, so the anchor needs to be converted to the parent's coordinate space
github-actions
bot
added
the
PR: out-of-date
mj12albert
force-pushed
the
popover-visual-viewport
branch
from
0ec196f to
d3f41a6
Compare
github-actions
bot
removed
the
PR: out-of-date
mj12albert
force-pushed
the
popover-visual-viewport
branch
from
d3f41a6 to
9f8e1ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures the popup stays anchored correctly when (pinch)zoomed
Components:
Tested with Chrome, Safari, Firefox (there are some cross-browser differences), iOS Safari & Chrome - open while zoomed, and also open then zoom/pan around
Fixes #17636
Fixes #23919
Fixes #39538