[select] Support single-pointer-cycle selection and pointer cancellation#48328
Open
mj12albert wants to merge 3 commits intomui:masterfrom
Open
[select] Support single-pointer-cycle selection and pointer cancellation#48328mj12albert wants to merge 3 commits intomui:masterfrom
mj12albert wants to merge 3 commits intomui:masterfrom
Conversation
mj12albert
added
accessibility
Bundle size
Deploy previewhttps://deploy-preview-48328--material-ui.netlify.app/ Check out the code infra dashboard for more information about this PR. |
mj12albert
requested review from
ZeeshanTamboli,
michelengelen,
silviuaavram and
siriwatknp
mj12albert
force-pushed
the
fix-select-pointer-interactions
branch
5 times, most recently
from
1e48e36 to
9e1c2f0
Compare
Comment on lines
+26
to
+27
| const SELECTED_MOUSE_UP_DELAY = 400; | ||
| const UNSELECTED_MOUSE_UP_DELAY = 200; |
Member
There was a problem hiding this comment.
I guess this fixes the bug reported in #46665: StackBlitz (this PR build)
mj12albert
force-pushed
the
fix-select-pointer-interactions
branch
from
464a14a to
7ca85a9
Compare
mj12albert
force-pushed
the
fix-select-pointer-interactions
branch
from
7ca85a9 to
c2af4fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-48328--material-ui.netlify.app/material-ui/react-select/
Matches Base UI's select's single pointer cycle:
pointerdown-> popup opens ->pointermoveto an option ->pointerup= selects the optionpointerdown-> popup opens ->pointermoveoutside the popup ->pointerup= popup closesCloses #45301
Closes #45374