[focus trap] Fix incorrect tab order when tabIndex >= 1#48546
Open
mj12albert wants to merge 2 commits into
Open
[focus trap] Fix incorrect tab order when tabIndex >= 1#48546mj12albert wants to merge 2 commits into
tabIndex >= 1#48546mj12albert wants to merge 2 commits into
Conversation
mj12albert
added
type: bug
Deploy previewhttps://deploy-preview-48546--material-ui.netlify.app/ Bundle size
Check out the code infra dashboard for more information about this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview: https://stackblitz.com/edit/yzacyhka-pvrbxm7l?file=package.json
The issue was that the keydown handler only special-cased
Shift+Tabfrom the trap root and otherwise let the browser choose the next focus target.When elements with
tabIndex >= 1exist, the browser’s next target after the positive sequence can be atabIndex 0element outside the trap instead of the next in-trap element.The fix intercepts these and moves focus through the trap’s
getTabbable()order.Fixes #36479