[code-infra] Collapse canary workflows into nightly and nightly-cron#48556
Open
Janpot wants to merge 2 commits into
Open
[code-infra] Collapse canary workflows into nightly and nightly-cron#48556Janpot wants to merge 2 commits into
Janpot wants to merge 2 commits into
Conversation
Collapse react-18-cron, react-next-cron, and typescript-next-cron into a single nightly-cron workflow. They all share the same 0 0 * * * cron and only differed in branch filters and job set. react@next jobs and test_types_next skip v5.x via per-job filters.branches.ignore so the existing per-branch coverage is preserved.
Janpot
added
the
scope: code-infra
Janpot
changed the title
Deploy previewhttps://deploy-preview-48556--material-ui.netlify.app/ Bundle size
Check out the code infra dashboard for more information about this PR. |
Replace react-18, react-next, and typescript-next with a single `nightly` manual workflow that mirrors `nightly-cron` (minus the branch filters, which don't apply to manual triggers). Trigger sources that pass workflow=react-18|react-next|typescript-next need to switch to workflow=nightly. The react-17 manual workflow is left in place.
Janpot
changed the title
Janpot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CircleCI config had six separate workflows for the same canary test suite — three manually-triggered (
react-18,react-next,typescript-next) and three scheduled (react-18-cron,react-next-cron,typescript-next-cron). Collapse them into two:nightly— manual; runs the full suite (react@18+react@next+typescript@next) when triggered withworkflow=nightlyon a PR.nightly-cron— scheduled daily at0 0 * * *onmaster,v5.x,v6.x.react@18jobs run on all three branches;react@nextandtest_types_nextskipv5.xvia per-jobfilters.branches.ignore, preserving the previous per-branch coverage.The manually-triggered
react-17workflow is left as-is (react-17-cronwas already disabled per the comment in the original config).This allows us to monitor a single workflow in code-infra