[code-infra] Convert @mui/private-theming to TypeScript#48565
Draft
Janpot wants to merge 1 commit into
Draft
Conversation
Janpot
added
type: enhancement
Deploy previewhttps://deploy-preview-48565--material-ui.netlify.app/ Bundle size
Check out the code infra dashboard for more information about this PR. |
Convert the package from hand-written `.js` + `.d.ts` to true TypeScript (single `.ts`/`.tsx` source, declarations emitted by `tsc`), removing the `--skipTsc` build. The exported type surface is unchanged, verified with a bidirectional type-equivalence probe; `unstable_nested` stays a runtime-only export via `@internal` + `stripInternal`.
Janpot
force-pushed
the
code-infra/private-theming-ts
branch
from
56299ee to
f305df7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
@mui/private-themingfrom hand-written.js+.d.tsto true TypeScript (single.ts/.tsxsource, declarations emitted bytsc), removing the--skipTscbuild — like@mui/utilsand@mui/styled-engine(#48544).The exported type surface is unchanged, verified with a bidirectional type-equivalence probe across the root and every subpath entry (
ThemeProvider,useTheme,defaultTheme). Emitted JS is byte-identical modulo comments; the.d.tsdifferences are limited to type-preserving form changes (import type,export type *,declare function).unstable_nestedstays a runtime-only export, absent from the public types as before, via@internal+stripInternal.@mui/systemgains atsconfig.build.jsonproject reference to the now-true-TS package.Published artifact diff
Diff of the published package before/after this PR:
@mui/private-theming3fa001f→f305df7