[autocomplete] Guard against null inputRef during unmount#48617
Merged
Conversation
Deploy previewhttps://deploy-preview-48617--material-ui.netlify.app/ Bundle size
Check out the code infra dashboard for more information about this PR. |
mj12albert
reviewed
Jun 3, 2026
mj12albert
added
scope: autocomplete
mj12albert
approved these changes
Jun 3, 2026
Member
mj12albert
left a comment
mj12albert
left a comment
There was a problem hiding this comment.
Thanks for the PR @noam3127
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a React 19 regression where
inputRef.currentis null whensyncHighlightedIndexToDOMruns during unmount, causingCannot read properties of null (reading 'removeAttribute'). React 19 cleans up refs before pending callbacks fire. Adds a null guard matching the existinglistboxRef.currentpattern. Originally fixed in #25311 but lost in the v9 rewrite.