TextField minimum rows can now be sensibly set.#693
Merged
hai-cea merged 3 commits intomui:masterfrom Jun 3, 2015
Merged
Conversation
Member
|
Thanks @super-cache-money Can you add propType validation here please? Also, do we need add the rows prop here to prevent it from being passed down to the input element? |
Contributor
Author
|
Cool - done. |
hai-cea
added a commit
that referenced
this pull request
Jun 3, 2015
TextField minimum rows can now be sensibly set.
Member
|
Thanks @super-cache-money ! |
|
I am now having this problem when the multiline text field is nested in a list. As soon as I type one character it expands. If the nested list is initially open, this does not happen. Using version 0.15.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By passing a number of rows as a prop to
TextField, the minimum number of rows occupied by a Text Field may now be set:This is useful, since the greater space occupied by a field in a text form encourages users to type more into it.
Observe the effect of this change on the above example:
Before:

After:
