Skip to content

Replace Click with TouchTap everywhere in the API and in docs#771

Merged
hai-cea merged 2 commits intomui:masterfrom
pomerantsev:fix/tap-instead-of-click
Jun 7, 2015
Merged

Replace Click with TouchTap everywhere in the API and in docs#771
hai-cea merged 2 commits intomui:masterfrom
pomerantsev:fix/tap-instead-of-click

Conversation

@pomerantsev
Copy link
Copy Markdown
Contributor

Fixes #769
Fixes #770

@pomerantsev
Copy link
Copy Markdown
Contributor Author

@hai-cea I guess we could still think about removing onItemClick from menu, since now all other components only support onTouchTap.
If we do so, #641 can be closed as well.
But maybe it's not a big deal - what's your opinion?

@hai-cea
Copy link
Copy Markdown
Member

hai-cea commented Jun 7, 2015

@pomerantsev Since this PR will introduce a breaking change, I think we should go ahead and remove onItemClick from menu as well. Would you like to do it in this PR?

@pomerantsev
Copy link
Copy Markdown
Contributor Author

@hai-cea Sure! Done.

hai-cea added a commit that referenced this pull request Jun 7, 2015
Replace Click with TouchTap everywhere in the API and in docs
@hai-cea hai-cea merged commit ba84faf into mui:master Jun 7, 2015
@hai-cea
Copy link
Copy Markdown
Member

hai-cea commented Jun 7, 2015

Thanks @pomerantsev !

@pomerantsev pomerantsev deleted the fix/tap-instead-of-click branch June 8, 2015 06:25
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Nov 10, 2020
@zannager zannager added the docs Improvements or additions to the documentation. label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Click is used in the name of a prop in DropDownIcon onClick is used instead of onTouchTap in docs

3 participants