[data grid] `preProcessEditCellProps` triggered after `onKeyDown` event for fields which are not currently editable

[atsoy]

Steps to reproduce

Steps:

1. Open this link to live example
2. Select one of the editable cells (column: Firstname)
3. Start editing by pressing e.g "k"

Current behavior

By starting editing with the key board application crashes with the message params.props is undefined.

Expected behavior

It should not crash, but continue editing the cell, without starting validation for currently not editable fields.

Context

No response

Your environment

npx @mui/envinfo

  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: preProcessEditCellProps, editable, onKeyDown, editMode

Order ID: 62555

[michelengelen]

Yes, @atsoy ... that does not make any sense.

This diff would fix it, but I am not sure if it can have side effects.

--- a/packages/x-data-grid/src/hooks/features/editing/useGridRowEditing.ts
+++ b/packages/x-data-grid/src/hooks/features/editing/useGridRowEditing.ts
@@ -460,6 +460,10 @@ export const useGridRowEditing = (
           const value = apiRef.current.getCellValue(id, field);
           const newValue = deleteValue ? getDefaultCellValue(column) : (initialValue ?? value);

+          if (!newProps[field]) {
+            return;
+          }
+
           Promise.resolve(
             column.preProcessEditCellProps!({
               id,

@kenanyusuf could you have a look next week, given you have touched this part last?

[atsoy]

Additional information: while I was implementing the workaround using the isCellEditable Prop, I've noticed that the isEditable flag from GridCellParams has the value false, but still it's possible to remove the value with the keyboard.

[atsoy]

Hey @michelengelen, don't want to be pushy, but are there any updates regarding this?

[michelengelen]

Not yet @atsoy :/

@arminmeh could you have a look if the suggested change would be ok?