Skip to content

Conversation

@Janpot
Copy link
Member

@Janpot Janpot commented Apr 29, 2025

Introduce new release:test command to run tests that only work after release:build. Used it to build a reproduction case for the mui/material-ui#45990

@github-actions
Copy link

Please add one type label to categorize the purpose of this PR appropriately:

bug, regression, enhancement, new feature, release or dependencies

@mui-bot
Copy link

mui-bot commented Apr 29, 2025

Deploy preview: https://deploy-preview-17612--material-ui-x.netlify.app/

Bundle size report

Total Size Change: 0B(0.00%) - Total Gzip Change: 0B(0.00%)
Files: 119 total (0 added, 0 removed, 0 changed)

Details of bundle changes

Generated by 🚫 dangerJS against 437f3ed

@alexfauquette
Copy link
Member

I tried to go a bit further in the bisection.

I tried to isolate the part of the pipeline that's breaking. To do so, I've took an other props highligtedItem that fails when running pnpm -F @mui/x-test-typescript typescript too.

And I re-implemented the props Type step by step removing the stuff that are not necessary for the definition on highligtedItem whihc is defined in the useChartHighlight pluggin (typed by UseChartHighlightSignature).

It stopped breaking when I isolated the pluggin removed the ...ChartCorePluginSignatures.

MergeSignaturesProperty<
      [
        // ...ChartCorePluginSignatures,
        ...TSignatures,
      ],
      'params'
    >

With the current state, the pnpm -F @mui/x-test-typescript typescript does not break, but uncommenting // ...ChartCorePluginSignatures makes it break

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label May 1, 2025
@github-actions
Copy link

github-actions bot commented May 1, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label May 1, 2025
@Janpot Janpot changed the title [code-infra] Reproduce strange core charts issue [code-infra] Add test case for core charts issue May 5, 2025
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label May 22, 2025
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels May 26, 2025
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label May 29, 2025
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jun 9, 2025
@github-actions
Copy link

github-actions bot commented Jun 9, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 9, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jul 1, 2025
@oliviertassinari oliviertassinari added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Aug 21, 2025
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 25, 2025
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: out-of-date The pull request has merge conflicts and can't be merged. scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants