[charts] Automatically use contrasting text color #17662
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCQuintas
added
type: new feature
|
Deploy preview: https://deploy-preview-17662--material-ui-x.netlify.app/ Updated pages: |
CodSpeed Performance ReportMerging #17662 will not alter performanceComparing Summary
|
Member
|
Doesn't seem to be working in all cases: 
|
Member
Author
Yeah, there are quite a few of the argos tests where that happens. |
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChartsContrastingTextcomponent that calculates a contrasting text color (black/white) from the providedtextBackgroundIMO if we want to go forward with this, we should probably change our palettes to consistently use only one of the colors to prevent issues like seen in some of the argos tests.