Skip to content

[DataGrid] Remove unnessary clsx() usages #17690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oliviertassinari merged 4 commits into from
May 7, 2025
Merged

[DataGrid] Remove unnessary clsx() usages #17690

oliviertassinari merged 4 commits into from
May 7, 2025

Conversation

@sai6855
Copy link
Contributor

@sai6855 sai6855 commented May 6, 2025 •
edited
Loading

This PR simplifies the codebase by removing unnecessary uses of the clsx utility

@github-actions
Copy link

github-actions bot commented May 6, 2025 •
edited
Loading

Thanks for adding a type label to the PR! 👍

@sai6855 sai6855 added internal Behind-the-scenes enhancement. Formerly called “core”. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. labels May 6, 2025
@mui-bot
Copy link

mui-bot commented May 6, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-17690--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 5f57d21

@flaviendelangle flaviendelangle changed the title [core] Remove unnessary clsx usages [DataGrid] Remove unnessary clsx usages May 6, 2025
@oliviertassinari oliviertassinari added the scope: data grid Changes related to the data grid. label May 6, 2025
@oliviertassinari
Copy link
Member

oliviertassinari commented May 6, 2025 •
edited
Loading

I have pushed another commit to cover the rest of the repository.

@sai6855 Can we do the same in Material UI? It seems that we have more dead code like this:

SCR-20250506-uidg

(Searching with clsx\([^,]*\))

@oliviertassinari oliviertassinari changed the title [DataGrid] Remove unnessary clsx usages [DataGrid] Remove unnessary clsx() usages May 6, 2025
@sai6855
Copy link
Contributor Author

sai6855 commented May 7, 2025 •
edited
Loading

Can we do the same in Material UI?

Updated here -> mui/material-ui#46084, there are still few similar instances but those are in joy-ui package, since we are not relasing joy-ui anymore, i haven't updated that code

@oliviertassinari
Copy link
Member

oliviertassinari commented May 7, 2025

@sai6855 Thanks. Yeah, agree, only Material UI needs to be updated.

@oliviertassinari oliviertassinari merged commit 4d231c8 into mui:master May 7, 2025
25 checks passed
@oliviertassinari oliviertassinari mentioned this pull request May 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenanyusuf kenanyusuf kenanyusuf approved these changes

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

Assignees

No one assigned

Labels

internal Behind-the-scenes enhancement. Formerly called “core”. performance scope: data grid Changes related to the data grid. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sai6855 @mui-bot @oliviertassinari @kenanyusuf