Skip to content

[telemetry] Fix ESM dynamic import #17720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hasdfa wants to merge 4 commits into from
Closed

[telemetry] Fix ESM dynamic import #17720

hasdfa wants to merge 4 commits into from

Conversation

@hasdfa
Copy link
Member

@hasdfa hasdfa commented May 6, 2025

Fixes #17587

@hasdfa hasdfa self-assigned this May 6, 2025
@hasdfa hasdfa added the scope: x-telemetry Changes related to the @mui/x-telemetry. label May 6, 2025
@github-actions
Copy link

github-actions bot commented May 6, 2025 •
edited
Loading

Thanks for adding a type label to the PR! 👍

@hasdfa hasdfa requested a review from michelengelen May 6, 2025 14:09
@mui-bot
Copy link

mui-bot commented May 6, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-17720--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 0744b4d

@michelengelen michelengelen added the type: bug It doesn't behave as expected. label May 6, 2025
@LukasTy LukasTy changed the title [x-telemetry] Fix esm dynamic import [telemetry] Fix ESM dynamic import May 9, 2025
LukasTy
LukasTy approved these changes May 9, 2025
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me if the move towards a static import does not have any negative side-effects. 👌
However, I think we have a problem in the build process...
All the imports get suffixed with .js, whereas dynamic imports don't. 🙈
cc @mui/code-infra

@Janpot
Copy link
Member

Janpot commented May 9, 2025 •
edited
Loading

All the imports get suffixed with .js, whereas dynamic imports don't.

That was actually fixed in the latest version of @mui/internal-babel-plugin-resolve-imports (2.0.1).
🙏 Thank you for doing the proper root cause analysis, I believe this would affect the exceljs import as well forget about that, it doesn't affect bare specifiers, I spoke too fast.

@Janpot Janpot mentioned this pull request May 9, 2025
Merged
@LukasTy
Copy link
Member

LukasTy commented May 9, 2025

@Janpot Thanks for remembering that fix. 👌
I've checked the built output on your PR, and it looks like it should fix the issue. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LukasTy LukasTy LukasTy approved these changes

@michelengelen michelengelen michelengelen approved these changes

Assignees

@hasdfa hasdfa

Labels

scope: x-telemetry Changes related to the @mui/x-telemetry. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[x-telemetry] Can't resolve './get-context' in '\node_modules\@mui\x-telemetry\esm\runtime'

5 participants

@hasdfa @mui-bot @Janpot @LukasTy @michelengelen