[x-license] use workspace dep for v9 in cross-major compat tests#22504
Merged
aemartos merged 7 commits intoMay 18, 2026
Merged
Conversation
aemartos
added
internal
Deploy previewhttps://deploy-preview-22504--material-ui-x.netlify.app/ Bundle size
Check out the code infra dashboard for more information about this PR. |
…of github.com:aemartos/mui-x into feature/sto-166-x-license-compat-use-workspace-for-v9
LukasTy
approved these changes
May 18, 2026
| // | ||
| // When v10 ships: | ||
| // - Switch the workspace dep target to the new major (i.e. v10 becomes the workspace). | ||
| // - Pin v9 here as an npm alias to its latest published 9.x. |
Member
There was a problem hiding this comment.
Could we also add the #npm-tag-reference into the comment so that this doesn't get lost?
And maybe link this PR for easier discoverability, just in case there are git blame issues?
aemartos
deleted the
feature/sto-166-x-license-compat-use-workspace-for-v9
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The cross-major license compat workspace was pinning
x-license-v9to a published npm version. That triggered a Renovate bump PR on every@mui/x-licenserelease, needless churn since v9 is the current major.This PR switches v9 to the existing
@mui/x-license: workspace:^dep, so the v9 row of the matrix auto-tracks whatever's in the repo. The older majors (v5–v8) stay pinned to specific published versions, that's still the point of the matrix.Side-effect: the
__ALLOW_TEST_LICENSES__transform plugin (added to patch the inlinedfalsein the published v9 bundle) is no longer needed, because the workspace source uses the unresolved token andvitest.shared.mtsalready defines it astrue. Removed.