Skip to content

[core] Resolve pnpm peer dep warnings#369

Merged
brijeshb42 merged 1 commit into
mui:masterfrom
brijeshb42:fix/peer-deps
Jan 20, 2025
Merged

[core] Resolve pnpm peer dep warnings#369
brijeshb42 merged 1 commit into
mui:masterfrom
brijeshb42:fix/peer-deps

Conversation

@brijeshb42
Copy link
Copy Markdown
Contributor

@brijeshb42 brijeshb42 commented Jan 17, 2025

Removes warnings when running pnpm i

 WARN  Issues with peer dependencies found
apps/local-ui-lib
├─┬ @emotion/react 11.13.3
│ ├── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021
│ └─┬ @emotion/use-insertion-effect-with-fallbacks 1.1.0
│   └── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021
├─┬ @emotion/styled 11.13.0
│ └── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021
└─┬ @pigment-css/react 0.0.30
  ├── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021
  └─┬ @mui/system 6.1.6
    ├── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021
    ├─┬ @mui/utils 6.1.6
    │ └── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021
    ├─┬ @mui/private-theming 6.1.6
    │ └── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021
    └─┬ @mui/styled-engine 6.1.6
      └── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021

docs
├─┬ @typescript-eslint/parser 7.6.0
│ └── ✕ unmet peer eslint@^8.56.0: found 9.17.0
└─┬ eslint-config-next 15.0.2
  └─┬ @typescript-eslint/eslint-plugin 7.6.0
    ├── ✕ unmet peer eslint@^8.56.0: found 9.17.0
    └─┬ @typescript-eslint/type-utils 7.6.0
      ├── ✕ unmet peer eslint@^8.56.0: found 9.17.0
      └─┬ @typescript-eslint/utils 7.6.0
        └── ✕ unmet peer eslint@^8.56.0: found 9.17.0

packages/eslint-plugin-material-ui
├─┬ @typescript-eslint/parser 7.6.0
│ └── ✕ unmet peer eslint@^8.56.0: found 9.17.0
└─┬ @typescript-eslint/experimental-utils 5.62.0
  ├── ✕ unmet peer eslint@"^6.0.0 || ^7.0.0 || ^8.0.0": found 9.17.0
  └─┬ @typescript-eslint/utils 5.62.0
    └── ✕ unmet peer eslint@"^6.0.0 || ^7.0.0 || ^8.0.0": found 9.17.0

packages/pigment-css-nextjs-plugin
├─┬ next 15.0.2
│ ├── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021
│ ├── ✕ unmet peer react-dom@18.3.1: found 19.0.0-rc-69d4b800-20241021
│ └─┬ styled-jsx 5.1.6
│   └── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021
└─┬ react-dom 19.0.0-rc-69d4b800-20241021
  └── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021

packages/pigment-css-plugin
├─┬ next 15.1.4
│ ├── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021
│ ├── ✕ unmet peer react-dom@18.3.1: found 19.0.0-rc-69d4b800-20241021
│ └─┬ styled-jsx 5.1.6
│   └── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021
└─┬ react-dom 19.0.0-rc-69d4b800-20241021
  └── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021

@brijeshb42 brijeshb42 added the internal Behind-the-scenes enhancement. Formerly called “core”. label Jan 17, 2025
Copy link
Copy Markdown
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left just one comment

Comment on lines +76 to +77
"react": "^17.0.0 || ^18.0.0 || ^19.0.0 || ^19.0.0-rc",
"react-dom": "^17.0.0 || ^18.0.0 || ^19.0.0 || ^19.0.0-rc"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to add the rc packages as well?

@mnajdova mnajdova changed the title [core] resolve pnpm peer dep warnings [core] Resolve pnpm peer dep warnings Jan 20, 2025
@brijeshb42
Copy link
Copy Markdown
Contributor Author

I have not tested it but saw it added in base ui so added here as well.

@brijeshb42 brijeshb42 merged commit 46f2088 into mui:master Jan 20, 2025
@brijeshb42 brijeshb42 deleted the fix/peer-deps branch January 20, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Behind-the-scenes enhancement. Formerly called “core”.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants