[core] Resolve pnpm peer dep warnings#369
Merged
Merged
Conversation
mnajdova
approved these changes
Jan 20, 2025
Comment on lines
+76
to
+77
| "react": "^17.0.0 || ^18.0.0 || ^19.0.0 || ^19.0.0-rc", | ||
| "react-dom": "^17.0.0 || ^18.0.0 || ^19.0.0 || ^19.0.0-rc" |
Member
There was a problem hiding this comment.
Do we really need to add the rc packages as well?
Contributor
Author
|
I have not tested it but saw it added in base ui so added here as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes warnings when running
pnpm iWARN Issues with peer dependencies found apps/local-ui-lib ├─┬ @emotion/react 11.13.3 │ ├── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021 │ └─┬ @emotion/use-insertion-effect-with-fallbacks 1.1.0 │ └── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021 ├─┬ @emotion/styled 11.13.0 │ └── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021 └─┬ @pigment-css/react 0.0.30 ├── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021 └─┬ @mui/system 6.1.6 ├── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021 ├─┬ @mui/utils 6.1.6 │ └── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021 ├─┬ @mui/private-theming 6.1.6 │ └── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021 └─┬ @mui/styled-engine 6.1.6 └── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021 docs ├─┬ @typescript-eslint/parser 7.6.0 │ └── ✕ unmet peer eslint@^8.56.0: found 9.17.0 └─┬ eslint-config-next 15.0.2 └─┬ @typescript-eslint/eslint-plugin 7.6.0 ├── ✕ unmet peer eslint@^8.56.0: found 9.17.0 └─┬ @typescript-eslint/type-utils 7.6.0 ├── ✕ unmet peer eslint@^8.56.0: found 9.17.0 └─┬ @typescript-eslint/utils 7.6.0 └── ✕ unmet peer eslint@^8.56.0: found 9.17.0 packages/eslint-plugin-material-ui ├─┬ @typescript-eslint/parser 7.6.0 │ └── ✕ unmet peer eslint@^8.56.0: found 9.17.0 └─┬ @typescript-eslint/experimental-utils 5.62.0 ├── ✕ unmet peer eslint@"^6.0.0 || ^7.0.0 || ^8.0.0": found 9.17.0 └─┬ @typescript-eslint/utils 5.62.0 └── ✕ unmet peer eslint@"^6.0.0 || ^7.0.0 || ^8.0.0": found 9.17.0 packages/pigment-css-nextjs-plugin ├─┬ next 15.0.2 │ ├── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021 │ ├── ✕ unmet peer react-dom@18.3.1: found 19.0.0-rc-69d4b800-20241021 │ └─┬ styled-jsx 5.1.6 │ └── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021 └─┬ react-dom 19.0.0-rc-69d4b800-20241021 └── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021 packages/pigment-css-plugin ├─┬ next 15.1.4 │ ├── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021 │ ├── ✕ unmet peer react-dom@18.3.1: found 19.0.0-rc-69d4b800-20241021 │ └─┬ styled-jsx 5.1.6 │ └── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021 └─┬ react-dom 19.0.0-rc-69d4b800-20241021 └── ✕ unmet peer react@18.3.1: found 19.0.0-rc-69d4b800-20241021