fix: encrypt AES key with RSA before server exchange#434
Merged
Conversation
Agent-Logs-Url: https://github.com/muke1908/chat-e2ee/sessions/80bba9d0-1121-4f81-bf67-b0822aef8216 Co-authored-by: muke1908 <20297989+muke1908@users.noreply.github.com>
Agent-Logs-Url: https://github.com/muke1908/chat-e2ee/sessions/80bba9d0-1121-4f81-bf67-b0822aef8216 Co-authored-by: muke1908 <20297989+muke1908@users.noreply.github.com>
|
Copilot
AI
changed the title
[WIP] Fix AES key exchange vulnerability through encryption
fix: encrypt AES key with RSA before server exchange
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The AES key used for WebRTC audio/video encryption was being transmitted to the server in plaintext, allowing the server to observe and potentially exploit it.
Changes
sdk.ts– AES key exchange already patched:shareEncryptedAesKey()RSA-OAEP encrypts the exported AES JWK with the receiver's public key before posting to the server;getPublicKey()decrypts the received ciphertext with the local RSA private key before importing it.cryptoAES.ts– Removed staleTODOcomment ongetRawAesKeyToExport()that incorrectly warned the key should not be transmitted (predated the RSA-wrapping fix).crypto.test.ts– Added test suiteAES key exchange via RSA-encrypted channelcovering: