Skip to content

Fix silent parsing errors #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jcenturion merged 1 commit into from
Sep 16, 2015
Merged

Fix silent parsing errors #179

jcenturion merged 1 commit into from
Sep 16, 2015

Conversation

@jcenturion
Copy link
Contributor

@jcenturion jcenturion commented Sep 16, 2015

Start showing parsing errors.

screen shot 2015-09-16 at 1 38 27 pm

@jcenturion jcenturion mentioned this pull request Sep 16, 2015
Closed
alejofernandez
alejofernandez reviewed Sep 16, 2015
View reviewed changes
dist/examples/simple.raml
Copy link
Contributor

@alejofernandez alejofernandez Sep 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent here is to create a malformed RAML, right?

Copy link
Contributor Author

@jcenturion jcenturion Sep 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sir.

@alejofernandez
Copy link
Contributor

alejofernandez commented Sep 16, 2015

LGTM 👍
Two minor suggestions, but I understand that probably it does not have too much sense to implement them now:

  • Use multiline instead of string concatenation for injecting templates
  • Change the name of malformed RAML files to make evident that they have errors

jcenturion added a commit that referenced this pull request Sep 16, 2015
@jcenturion
Merge pull request #179 from mulesoft/bugs/silent-errors
4fc77fb 
Fix silent parsing errors
@jcenturion jcenturion merged commit 4fc77fb into master Sep 16, 2015
@jcenturion jcenturion deleted the bugs/silent-errors branch September 16, 2015 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jcenturion @alejofernandez