Use new Button component instead of AppButton#7842
Merged
MarkusPettersson98 merged 46 commits intomainfrom Apr 30, 2025
Merged
Conversation
olmoh
force-pushed
the
replace-remaining-buttons-with-new-button-component-des-1794
branch
from
17ba337 to
4617c1b
Compare
olmoh
force-pushed
the
replace-remaining-buttons-with-new-button-component-des-1794
branch
from
df3f606 to
10deb30
Compare
olmoh
changed the title
olmoh
force-pushed
the
replace-remaining-buttons-with-new-button-component-des-1794
branch
from
10deb30 to
4df524c
Compare
olmoh
force-pushed
the
replace-remaining-buttons-with-new-button-component-des-1794
branch
from
4df524c to
3002a32
Compare
Contributor
tobias-jarvelov
left a comment
tobias-jarvelov
left a comment
There was a problem hiding this comment.
Looks okay when reading the code. However I'm gonna test it out locally as well. Don't have time to do it now though so I'll just leave my comments meanwhile.
desktop/packages/mullvad-vpn/src/renderer/lib/hooks/use-exclusive-task.tsx
Outdated
Show resolved
Hide resolved
desktop/packages/mullvad-vpn/src/renderer/lib/hooks/use-exclusive-task.tsx
Outdated
Show resolved
Hide resolved
olmoh
force-pushed
the
replace-remaining-buttons-with-new-button-component-des-1794
branch
5 times, most recently
from
07fe023 to
849a762
Compare
olmoh
force-pushed
the
replace-remaining-buttons-with-new-button-component-des-1794
branch
5 times, most recently
from
785e315 to
6780bf0
Compare
olmoh
force-pushed
the
replace-remaining-buttons-with-new-button-component-des-1794
branch
from
6780bf0 to
a755eb4
Compare
olmoh
force-pushed
the
replace-remaining-buttons-with-new-button-component-des-1794
branch
from
2bfa841 to
39ede89
Compare
tobias-jarvelov
approved these changes
Apr 30, 2025
MarkusPettersson98
force-pushed
the
replace-remaining-buttons-with-new-button-component-des-1794
branch
from
39ede89 to
eeda8e8
Compare
MarkusPettersson98
deleted the
replace-remaining-buttons-with-new-button-component-des-1794
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is