Merged
Conversation
olmoh
force-pushed
the
create-animateheight-component-des-1897
branch
from
b0f3b12 to
98e046c
Compare
Collaborator
Author
|
Makes sense to add some sort of duration parameter to the component, but since we don't have any duration tokens specified at the moment I have left that out for now. |
| case 'present-vertical': | ||
| return <AnimatePresentVertical {...props} />; | ||
| default: | ||
| return null; |
Contributor
There was a problem hiding this comment.
In case you want to exhaust your switch and get a type-error when it is not:
Suggested change
| return null; | |
| return type satisfies never; |
I know it goes against your return null but since it should never happen...
Collaborator
Author
There was a problem hiding this comment.
Good suggestion, have implemented this. Thanks for the feedback! :)
tobias-jarvelov
previously approved these changes
Mar 24, 2025
olmoh
force-pushed
the
create-animateheight-component-des-1897
branch
2 times, most recently
from
f123d08 to
7a32491
Compare
tobias-jarvelov
approved these changes
Mar 25, 2025
MarkusPettersson98
approved these changes
Mar 26, 2025
Contributor
MarkusPettersson98
left a comment
MarkusPettersson98
left a comment
There was a problem hiding this comment.
Reviewed 2 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MrChocolatine)
MarkusPettersson98
force-pushed
the
create-animateheight-component-des-1897
branch
from
7a32491 to
325c699
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is