Skip to content

Conversation

@pronebird
Copy link
Contributor

@pronebird pronebird commented May 28, 2025

Hi,

I am not entirely sure but I think this fuse() is unnecessary given that None is being handled in the loop. Let's see if CI can compile that.


This change is Reviewable

Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The select! macro we're using requires the future to implement FusedFuture, which futures::channel::mpsc::UnboundedReceiver does not do. We invoke fuse() to get a Fuse<UnboundedReceiver>, which does implement FusedFuture.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants