HV3D+ preprocessing: Fix bug related to repeated coordinates#41
Merged
MLopez-Ibanez merged 4 commits intomainfrom Nov 29, 2025
Merged
HV3D+ preprocessing: Fix bug related to repeated coordinates#41MLopez-Ibanez merged 4 commits intomainfrom
MLopez-Ibanez merged 4 commits intomainfrom
Conversation
…inates. * hv_priv.h (compute_area_simple): Change assertions.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
+ Coverage 73.39% 73.49% +0.10%
==========================================
Files 58 58
Lines 5041 5049 +8
Branches 964 970 +6
==========================================
+ Hits 3700 3711 +11
+ Misses 964 961 -3
Partials 377 377
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
|
Thank you! Rather than removing the assertion, I have relaxed it to accept area == 0 (but not area < 0). I have also added the testcase to the testsuite (with all permutations of the columns): multi-objective/testsuite@5b3fa6d |
baf67c2 to
589b9ae
Compare
MLopez-Ibanez
added a commit
that referenced
this pull request
Nov 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in the preprocessing procedure of HV3D+ related to repeated coordinates. A testcase for this bug is:
Although the bug should not lead to incorrect results when using HV3D+, the data structure is not setup as intended. A side effect is that the preprocessing may take longer because the AVL tree may (unnecessarily) keep many points that are weakly dominated in the (x,y)-plane. To check this, we can use a testcase with$n$ points generated like this:
For large$n$ , it is possible to see that the previous version of the code would take longer.