Added tests for invalid Base16 input + made Base enum immutable #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sic2
commented
Mar 10, 2018
sic2
commented
- Fixed tests which were not comparing the encoded strings with the expected output
- Made tests for invalid Base16 input
- made Base enum immutable
sic2
added a commit
to sic2/java-multiaddr
that referenced
this pull request
Mar 10, 2018
ianopolous
reviewed
Mar 10, 2018
| Base8('7'), // highest char in octal | ||
| Base10('9'), // highest char in decimal | ||
| Base16('f'), // highest char in hex | ||
| Base32('b'), // highest char in hex |
ianopolous
reviewed
Mar 11, 2018
| import java.math.BigInteger; | ||
|
|
||
| /** | ||
| * @author Simone I. Conte "sic2@st-andrews.ac.uk" |
Member
There was a problem hiding this comment.
I like the idea of this class, but 99% of the code is not yours, so probably better off without the explicit author comment
Contributor
Author
There was a problem hiding this comment.
oh sorry, IntelliJ put it there. I did not mean to gain authorship of this.
ianopolous
approved these changes
Mar 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.