Conversation
|
|
||
| > JavaScript implementation of the multicodec specification | ||
|
|
||
| ## Lead Maintainer |
There was a problem hiding this comment.
Shouldn't this be moved to Maintainers section in the end of the README? Because there's already one
There was a problem hiding this comment.
good catch. Forgot to delete it. We want it at the top :)
|
@hacdias look at that, one of the test runs are failing, you already have something to do :D |
|
@diasdavid it seems that upgrading Aegir is the cause of CI errors - you can see with my previous commit that downgrades Aegir that everything is passing now. It only happens on macOS with Node 9.2.0 and it seems to be a Segmentation Fault within Aegir, which is kind of strange. I can't reproduce it on my machine with the latest release of Aegir. It seems to be very specific. |
|
@victorbjelkholm as far as I can see you were the responsible for most of the latest releases of Aegir. Do you have any idea of what might be causing this? Or even something on Jenkins |
|
@hacdias you can approve this PR, merge it and handle aegir separate. |
|
@diasdavid sure. Although I don't have permissions to merge this. |
|
@hacdias are you sure? You are part of the JavaScript team -- https://github.com/orgs/multiformats/teams/javascript-team/members -- which has perms to merge PRs on this repo. |
|
|
| "coverage": "aegir coverage", | ||
| "coverage-publish": "aegir coverage --provider coveralls" | ||
| }, | ||
| "pre-commit": [ |
There was a problem hiding this comment.
This should not be removed, but changed to pre-push.
|
Thanks @hacdias, I've written the GitHub support about the permission issue and hopefully they can help us out. |
|
@hacdias can you try merging this again? We might have been a bit overzealous when it comes to the branch protection. |
|
Commit ipfs-inactive/ci-sync@ca8f090 has fixed the branch protection permission in all js-* repos. |
|
@victorbjelkholm done 😄 Thanks! |
4 participants
For ipfs/community#301