Skip to content

feat: beeson support#286

Merged
rvagg merged 1 commit intomultiformats:masterfrom
molekilla:feat-swarm-beeson
Sep 5, 2022
Merged

feat: beeson support#286
rvagg merged 1 commit intomultiformats:masterfrom
molekilla:feat-swarm-beeson

Conversation

@molekilla
Copy link
Copy Markdown
Contributor

@molekilla molekilla commented Sep 2, 2022

Adds BeeSon support
Copy link
Copy Markdown
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, I was going to say this should be serialization but I note we have cbor, json and raw as ipld (I remember them being serialization but perhaps not..)

@vmx?

Copy link
Copy Markdown
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The categories are fuzzy. At least using ipld for this one seems to be consistent.

@rvagg
Copy link
Copy Markdown
Member

rvagg commented Sep 5, 2022

Ah, it actually has its own link type:

The swarmCac and swarmSoc are misc types that are deserialized as regexed strings according to the rules of Swarm CIDs. Additionally, the serialization can interpret the CID object used in swarm-cid-js.

presumably these could be interpreted as multiformats CIDs and therefore be viewed as actual IPLD; bonus.

@rvagg rvagg merged commit d95df3a into multiformats:master Sep 5, 2022
@molekilla
Copy link
Copy Markdown
Contributor Author

thanks guys !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants