Recommend pymultihash instead of the defunct python-multihash#102
Merged
Stebalien merged 1 commit intomultiformats:masterfrom Sep 28, 2018
Merged
Recommend pymultihash instead of the defunct python-multihash#102Stebalien merged 1 commit intomultiformats:masterfrom
pymultihash instead of the defunct python-multihash#102Stebalien merged 1 commit intomultiformats:masterfrom
Conversation
Stebalien
approved these changes
Sep 28, 2018
Member
|
It has a few small issues (reported) but looks pretty good overall (and it still exists which is a huge plus...). |
Member
|
Thanks! |
Contributor
Author
|
What's your stance on moving it to the organization? |
Member
|
@Alexander255 ideally, I'd like to have ivilata/pymultihash#5 and ivilata/pymultihash#7 fixed first so users don't run into any nasty incompatibilities. After that, I see no reason not to. @diasdavid do we have a policy for onboarding libraries into our organizations? |
Contributor
|
Hey, it's an honor to read that this is now a recommended implementation! 😄 Regarding the two issues, I currently have no time to concentrate on them (this might get better in a couple of months), but pull requests are very welcome. I'd also be happy to delegate maintenance if need be. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo of the currently recommend multihash implementation doesn't even exist anymore. @ivilata's implementation of multihash on-the-other hand is quite feature-complete, comes with good documentation and was positively received by previous
py-ipfsdevelopers. The heavy-lifting is done by Python's built-inhashlibmodule that python developers are already familiar with. Hence I believe this should become the recommended implementation for python. If @ivilata isn't opposed to it, I believe it should also be moved to the organization (as https://github.com/multiformats/py-multihash).