feat: add recommendation for consolidating packets#20
Merged
Conversation
Stebalien
approved these changes
Mar 14, 2020
Stebalien
force-pushed
the
feat/consolidate
branch
from
da96f57 to
d851e42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an implementation recommendation to consolidate multistream protocol negotiation with the desired action (protocol selection, ls).
Some implementations (go, rust) already do this, but others do not (js, python). If all implementations conform to the recommendation it should help reduce unnecessary round trips.
related: rust and js interop