Skip to content

src/protocol.rs: Add /webtransport#70

Merged
mxinden merged 3 commits intomultiformats:masterfrom
jxs:add-web-transport-support
Dec 16, 2022
Merged

src/protocol.rs: Add /webtransport#70
mxinden merged 3 commits intomultiformats:masterfrom
jxs:add-web-transport-support

Conversation

@jxs
Copy link
Copy Markdown
Contributor

@jxs jxs commented Dec 9, 2022

addresses #68

Copy link
Copy Markdown
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing update to Arbitrary implementation. See also #65.

Otherwise this looks good to me. Thanks @jxs!

Copy link
Copy Markdown
Contributor Author

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Max, updated!

Copy link
Copy Markdown
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise this looks good to me. Thanks.

Comment thread CHANGELOG.md
@@ -1,3 +1,9 @@
# 0.18.0 [unreleased]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing version bump in Cargo.toml.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry Max! Updated

Copy link
Copy Markdown
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful. Thanks!

@mxinden mxinden merged commit 2a754e2 into multiformats:master Dec 16, 2022
oblique pushed a commit to oblique/rust-multiaddr that referenced this pull request Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants