core: drain seccomp notifications via AsyncFd, remove per-sandbox blocking thread#50
Merged
Conversation
…hread Signed-off-by: Cong Wang <cwang@multikernel.io>
Signed-off-by: Cong Wang <cwang@multikernel.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the per-sandbox blocking-recv thread in the seccomp supervisor with a tokio AsyncFd registration on the notif fd. Each live sandbox is now one fewer OS thread parked in `ioctl(SECCOMP_IOCTL_NOTIF_RECV)`.
Independent of #49: this branch is rooted on `origin/main`. The two PRs touch disjoint files (FFI/Python vs. `sandlock-core`) and should merge cleanly in either order.
What changes
`seccomp/notif.rs` — supervisor rewrite:
`sandbox.rs` — supervisor startup synchronization:
Second commit is a refactor of the drain loop into a `NotifFdState` enum (`Pending` / `Empty` / `Terminal`) + `probe_notif_fd` helper. Same behavior, three-arm `match` reads in English; the POLLHUP-spin bug becomes structurally hard to reintroduce.
Why this is the right pattern
Test plan