Feature request: Allow requesting a review without also pinging them in a comment

[kolayne]

I use codeowners-plus to select and assign reviewers but do not enforce approvals. Codeowners-plus will assign a reviewer, and then additionally leave a comment pinging that reviewer. This has two problems:

1. The comment says that an approval is required, which is false: the approval enforcement is disabled.
2. The reviewer receives an extra unnecessary email.

I'd like to have the option to just have the review requested, not leaving the comment.

[kolayne]

I can contribute a patch to implement that. Though, we need to agree on the right way to implement it.

The most straightforward way that would resolve both problems would be to only leave the comment if the enforcement is enabled.

Though, I wonder if some users would like to get rid of these comments while keeping the enforcement on, i.e., have the check fail without commenting on the PR. Should we implement a new setting for this case? How would you like it to behave?

[BakerNet]

I can contribute a patch to implement that. Though, we need to agree on the right way to implement it.

The most straightforward way that would resolve both problems would be to only leave the comment if the enforcement is enabled.

Though, I wonder if some users would like to get rid of these comments while keeping the enforcement on, i.e., have the check fail without commenting on the PR. Should we implement a new setting for this case? How would you like it to behave?

I think just adding a config option to disable the issue comments that ping users (e.g. Config.DisableComments in config.go) is a straightforward and good addition.

You can actually already disable enforcement with the Enforcement.FailChecks flag:

approval = true
# `fail_check` (default true) means the codeowners GHA check will fail if the codeowners check fails
fail_check = false

It's a common use case to have the check fail disabled but still want the comments (we do this internally) - so definitely don't want to piggyback on the same config option.