Cohort self-selection and testing. #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue with validators not working unless we first clear the tables
Now works better on mobile too
Add explanation for yellow cells Change wording for # local MBEs contracted Add FY17 to wording Remove decimal point from dollar amount Made table expand automatically upon page load Increase range for yellow cells to 1 billion
Update wording and template
Participation links are internally linked to the cohort that was self selected by contributors. Make sure this link is not revealed to the analyst when checking the history or retrieving previous generated participation links. Solution: if cohort self selection is on, always override cohort id with undefined (for no cohort) in server response to get_client_urls. Otherwise (no cohorts, or pre-assigned) keep cohort mapping as it is.
…ver side and client side)
|
Commit closes #157 |
This was referenced Jun 25, 2019
This was referenced Jun 25, 2019
…ent side code simplification. Various linting changes
This was referenced Jun 27, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging to master cohort self selection with selenium tests.