Enforce lockfile floors for time and bytes#804
Merged
multiplex55 merged 2 commits intomasterfrom Feb 7, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
timeandbytesresolve to known-safe minimums to avoid accidental downgrades or incompatibilities.Description
Cargo.toml:time = ">=0.3.47, <0.4"andbytes = ">=1.11.1, <2"to express the required minimums.Cargo.locksotimeresolves to0.3.47andbytesresolves to1.11.1(remove older resolved versions for those crates).tests/dependency_floor_guard.rs, a deterministic, offline-safe test that parsesCargo.lock, asserts each crate appears exactly once, and verifiestime >= 0.3.47andbytes >= 1.11.1, including a localSemVerhelper and unit tests for the helper.README.mdto document the enforcement command for maintainers:cargo test --test dependency_floor_guard.Testing
cargo update -p time --precise 0.3.47 && cargo update -p bytes --precise 1.11.1, which succeeded and updatedCargo.lockto the targeted versions.Cargo.lockand confirmedtimeis0.3.47andbytesis1.11.1.cargo test --test dependency_floor_guardon the environment default toolchain which failed becausetime 0.3.47requiresrustc 1.88.0.cargo +1.88.0 test --test dependency_floor_guard, which progressed but the build ultimately failed in this Linux environment due to a missing systemalsadevelopment library required by a transitive native crate, not due to the guard test logic itself.Codex Task