Add configurable query-results grid layout with keyboard navigation#900
Merged
multiplex55 merged 2 commits intomasterfrom Feb 20, 2026
Merged
Add configurable query-results grid layout with keyboard navigation#900multiplex55 merged 2 commits intomasterfrom
multiplex55 merged 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
QueryResultsLayoutSettingstosrc/settings.rswith serde defaults and aDefaultimpl, and wired it intoSettings::default()and (de)serialization so existing configs remain compatible. (fields:enabled,rows,cols,respect_plugin_capability,plugin_opt_out).SettingsEditorinsrc/settings_editor.rswith fields for the layout, populated them inSettingsEditor::new(...), converted back into_settings(...)(rows/cols clamped to >=1), and added UI controls (toggle, numeric rows/cols, capability-respect toggle and comma-separated plugin opt-out). Changes are applied to runtimeLauncherAppimmediately when saved.query_results_layout+resolved_grid_layouttoLauncherAppinsrc/gui/mod.rs, recompute hooks (should_use_grid_layout/recompute_query_results_layout), and wire recompute calls into search and settings-apply flows so edits take effect immediately. Implemented a grid rendering path (egui::Grid) for the main query results pane while preserving the existing vertical list as a fallback and handling overflow/scrolling naturally.src/plugin.rs(grid_results_compatibleandforce_list_results) and implemented logic inLauncherApp::should_use_grid_layoutthat resolves grid vs list based on active plugins, capability presence, and the opt-out list; mixed or ambiguous sources fall back to list mode.LauncherApp::handle_key(...)to support Left/Right and numpad2/4/6/8for 2D navigation in grid mode, while preserving list behavior in list mode and keepingEnteractivation semantics.src/settings.rs,src/settings_editor.rs, andsrc/gui/mod.rstest modules).Testing
cargo fmtto format the code; it completed successfully.cargo testin this environment failed with apkg-config/alsa.pcerror fromalsa-sysduring compilation, so automated tests could not be completed here.src/settings.rs), settings-editor conversion & clamping (src/settings_editor.rs), grid navigation and plugin capability/resolution (src/gui/mod.rs), intended to pass when dependencies and native build tools are available.Codex Task