Use borrowed zero-allocation check for search capability in PluginManager::search_filtered#924
Merged
multiplex55 merged 1 commit intomasterfrom Mar 8, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Stringjust to check whether a plugin's enabled capabilities include"search", and ensure plugins without that capability are skipped during search routing.Description
caps.contains(&"search".to_string())with a zero-allocation borrowed comparisoncaps.iter().any(|c| c == "search")inPluginManager::search_filtered.search_capability_gate_skips_plugin_when_disabledintests/plugin_routing.rsto verify a plugin is skipped when its enabled capabilities do not include"search".HashSetin this change;Vec<String>callsites remain unchanged for minimal scope.Testing
cargo fmt --all, which succeeded.cargo test --test plugin_routingandcargo test --test plugin_routing --no-default-features, but both failed in this environment due to a missing systemalsadevelopment library required byalsa-sys, so the new test could not be executed here.Codex Task