Player crouched state resets after setPedAnimation() was called

[Einheit-101]

Describe the bug
As soon as you use setPedAnimation() while the player is crouched, he will stand up after finishing the animation. This bug now hits especially hard because custom animations open a new world for scripters.

To Reproduce
Steps to reproduce the behavior:

1. Go to map editor, press F5 for testing
2. Crouch the player
3. Open freeroam menu with F1, open "anim" tab
4. Apply any animation and stop it again
5. Player will stand up after that

Expected behavior
The player should stay crouched, this bug makes it hard / impossible to play certain animations while crouching (For example "crouch_roll_r" will let the player roll right but he stands up, which is not what i want)

MTA Version 1.5.6-release-14378

[patrikjuvonen]

#488 might be related

@qaisjp What do you think? When setPedAnimation is done executing, the crouch state should be restored if ped was ducked?
@Einheit-101 Does this happen with other tasks as well? or is it only crouch?

[Einheit-101]

Uhm i dont know of any task that could get cut off, i think you stop climbing but thats expected behaviour.

[qaisjp]

@qaisjp What do you think? When setPedAnimation is done executing, the crouch state should be restored if ped was ducked?

What do you think about an extra argument, retainPedState? The wording is vague enough for other similar things to be clustered into this setting later.

[Einheit-101]

This sounds good, but even better may be a "pedState" setting: "crouching" or "standing", the Ped/Player will do whatever you write in that argument when the Animation is finished.

What do you think about an extra argument, retainPedState? The wording is vague enough for other similar things to be clustered into this setting later.

I like @Einheit-101 's idea. However, I'd prefer to pass the name of a control state which will be set after the ped is done playing the animation. I'll do it if it's not so difficult to accomplish.

Fixed in 49ffc91 . Let me know if there's any problem.