WIP: Add new event onClientWorldSound #133
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i love you |
Contributor
|
Not sure about the feasibility of this event, but it's probably best to keep the name as "world sound" to make it open to supporting more groups in the future. |
Author
|
I reverted that specific commit to keep the onClientWorldSound event name, but I left the restriction for players and peds there. |
Necktrox
changed the title
CrosRoad95
reviewed
May 13, 2017
There was a problem hiding this comment.
sound can be from example: vehicles, explosion vehicle/barrels/gas station etc, weapons, destroyed objects
so, if element isnt ped/player then source=nil
Author
There was a problem hiding this comment.
- The pull request description tackles this issue: The hooked GTA:SA function doesn't handle a lot of sounds and that's why it is restricted to player/ped entities, because you can only cancel these.
- The source element can never be nil, it's either the source element or root
added 4 commits
July 9, 2017 19:59
This reverts commit b3ed2d69c7380ad90706ab1617aab3ae9c1d390a.
Necktrox
force-pushed
the
feature/world-sound-event
branch
from
89d1ab1 to
d2ca755
Compare
botder
changed the title
patrikjuvonen
changed the title
Member
|
Added in 8302b4c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a new event called
onClientWorldSound. The event is restricted to players and peds. This comes in handy if you want to replace the step sounds whenever a player or ped emits these (doesn't work with server-side created peds).The provided GTA:SA hook is not able to cancel every sound emitted. While testing I discovered it detects the random gun shooting with a NULL entity, but to my disappointment, you couldn't detect various other sounds.
I have restricted the event to player/ped related sounds. Scripters can use this event to cancel the step sounds (IIRC it was group 5) to add their own sounds (maybe even use the material the player/ped is standing on) or to use the sound position in a popular gamemode called DayZ.
Issues:
#9606: [Request] onPedTakeStep
#7074: onClientWorldSound not canceled (relevant, but not solved due to sound-canceling issues)
Images