Skip to content

Fix building OOP API #3614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 28, 2024
Merged

Fix building OOP API #3614

merged 3 commits into from
Aug 28, 2024
+9 −5

Conversation

@TheNormalnij
Copy link
Member

@TheNormalnij TheNormalnij commented Jul 28, 2024

  1. Make rotation argument optional.
  2. Fix OOP methods
local b = Building(1337, 0, 0, 4)
iprint(b.position)

@TheNormalnij TheNormalnij added the bugfix Solution to a bug of any kind label Jul 28, 2024
@TheNormalnij TheNormalnij added this to the 1.6.1 milestone Jul 28, 2024
FileEX
FileEX requested changes Jul 31, 2024
View reviewed changes
@Fernando-A-Rocha
Copy link
Contributor

Fernando-A-Rocha commented Aug 18, 2024

PR should be renamed to Fix building OOP and make rotation arg optional

@TheNormalnij TheNormalnij force-pushed the TheNormalnij/fix_building_api branch from b78d058 to 2ff90bf Compare August 21, 2024 16:59
@tederis tederis merged commit b766ed1 into multitheftauto:master Aug 28, 2024
MTABot pushed a commit that referenced this pull request Aug 28, 2024
@github-actions
Synchronize changes from 1.6 master branch [ci skip]
b6f4a21 
b766ed1 Fix building OOP API (#3614)
79a6c44 Visual Studio Update
@TheNormalnij TheNormalnij deleted the TheNormalnij/fix_building_api branch August 28, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FileEX FileEX FileEX requested changes

@tederis tederis tederis approved these changes

Assignees

No one assigned

Labels

bugfix Solution to a bug of any kind

Projects

None yet

Milestone

1.7

Development

Successfully merging this pull request may close these issues.

4 participants

@TheNormalnij @Fernando-A-Rocha @tederis @FileEX