Skip to content

Fix onClientWorldSound event cancellation for non-entity sounds (#3269) #4416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2025
Merged

Fix onClientWorldSound event cancellation for non-entity sounds (#3269) #4416

merged 2 commits into from
Sep 4, 2025

Conversation

@MohabCodeX
Copy link
Contributor

The WorldSoundHandler only fired the onClientWorldSound event when event.pGameEntity was not null, preventing cancellation of sounds without entity associations.

All world sounds now fire the onClientWorldSound event and can be cancelled.

Closes #3269

@FileEX FileEX added the bugfix Solution to a bug of any kind label Sep 4, 2025
@FileEX FileEX merged commit e490616 into multitheftauto:master Sep 4, 2025
MTABot pushed a commit that referenced this pull request Sep 4, 2025
@github-actions
Synchronize changes from 1.6 master branch [ci skip]
2c23624 
e490616 Fix `onClientWorldSound` event cancellation for non-entity sounds (#3269) (#4416)
@MohabCodeX MohabCodeX deleted the fix/cancel-world-sound branch September 5, 2025 08:38
@FileEX FileEX added this to the 1.7.1 milestone Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FileEX FileEX FileEX approved these changes

Assignees

No one assigned

Labels

bugfix Solution to a bug of any kind

Projects

None yet

Milestone

1.7.1

Development

Successfully merging this pull request may close these issues.

onClientWorldSound is only cancellable for vehicles sounds

2 participants

@MohabCodeX @FileEX