Skip to content

Fix broken CI by patching GitHub Actions back to vs2022#4607

Merged
qaisjp merged 7 commits intomasterfrom
qaisjp-fix-github-actions
Jan 7, 2026
Merged

Fix broken CI by patching GitHub Actions back to vs2022#4607
qaisjp merged 7 commits intomasterfrom
qaisjp-fix-github-actions

Conversation

@qaisjp
Copy link
Copy Markdown
Member

@qaisjp qaisjp commented Jan 6, 2026

Visual Studio 2026 isn't ready on GitHub Actions, so the upgrade to 2026 around this time period causes GitHub Actions builds to stop succeeding.

Since we can't upgrade to Visual Studio 2026 yet (actions/runner-images#13291), this change temporarily restores VS 2022 just for the purpose of CI.

Additionally this change clarifies how to install MFC v145, since the text has changed in the Visual Studio installer.

Test plan

CI should pass

Safe to revert?

Yes

@qaisjp qaisjp changed the title Fix broken CI Enable vs2026 in CI Jan 6, 2026
qaisjp added 6 commits January 6, 2026 15:25
Updated the restore vs2022 step to include fetching and checking out README.md after reverting.
Clarified prerequisites for Visual Studio installation.
Updated the restore process for vs2022 to use a no-commit revert.
@qaisjp qaisjp changed the title Enable vs2026 in CI Fix broken CI by patching GitHub Actions back to vs2022 Jan 6, 2026
@qaisjp qaisjp marked this pull request as ready for review January 6, 2026 23:47
@qaisjp qaisjp enabled auto-merge (squash) January 6, 2026 23:47
@qaisjp qaisjp requested a review from MegadreamsBE January 7, 2026 00:19
@qaisjp qaisjp merged commit 2502205 into master Jan 7, 2026
16 checks passed
@qaisjp qaisjp deleted the qaisjp-fix-github-actions branch January 7, 2026 00:25
MTABot pushed a commit that referenced this pull request Jan 7, 2026
2502205 Fix broken CI by patching GitHub Actions back to vs2022 (#4607)
qaisjp added a commit that referenced this pull request Jan 19, 2026
Visual Studio 2026 isn't ready on GitHub Actions, so [the upgrade to
2026](c757a89)
around [this time
period](https://github.com/multitheftauto/mtasa-blue/commits/master/?after=1c590fbc46884bb25809d85d1017c08f779c6a28+104)
causes GitHub Actions builds to stop succeeding.

Since we can't upgrade to Visual Studio 2026 yet
(actions/runner-images#13291), this change
temporarily restores VS 2022 just for the purpose of CI.

Additionally this change clarifies how to install MFC v145, since the
text has changed in the Visual Studio installer.

**Test plan**

CI should pass

**Safe to revert?**

Yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants