Skip to content

Conversation

@andreiblt1304
Copy link
Contributor

@andreiblt1304 andreiblt1304 commented Jan 14, 2025

Description of the pull request (what is new / what has changed)

Did you test the changes locally ?

  • yes
  • no

Which category (categories) does this pull request belong to?

  • document new feature
  • update documentation that is not relevant anymore
  • add examples or more information about a component
  • fix grammar issues
  • other

@andreiblt1304 andreiblt1304 marked this pull request as ready for review January 14, 2025 12:55
@@ -0,0 +1,9 @@
# Cross-Chain Execution Example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this linked to the docs?

@@ -0,0 +1,18 @@
# Creating Bridges
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This title is confusing. Creating bridges between what to what should be the answer? At this point in time, a normal user, first time visitor will have no clue to what kind of bridges we are reffering to. Even though we may think that it is obvious (it may be for us) that the topic of this page is the bridge btw MainChain to Sovereign and the other way around, it is not.


## What is Cross-Chain Execution?

Being able to connect 2 different ecosystems opens up infinite possibilities for functionality. Cross-Chain Execution implies using the functionality of two different chains and combining both of them. In this context we can refer to:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same thing as above:

A new user will ask himself:
"two chains" - Is it Ethereum and Solana? or what chains are you referring to?


Being able to connect 2 different ecosystems opens up infinite possibilities for functionality. Cross-Chain Execution implies using the functionality of two different chains and combining both of them. In this context we can refer to:

1. Sending tokens from one chain to another
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Better define from what Chain to what Chain. Probably it will be better to have a note above where you define what MainChain is and what Sovereign Chain is.


## Cross-Chain Execution within Sovereign Chains

All the heavy lifting is being done by the *ESDT-Safe* Smart Contract.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this Smart Contract described in detail? if it is not, let's create a page for it. If it is, add a link to that description.

@@ -0,0 +1,42 @@
# To Sovereign
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To sovereign but from where? From another Sovereign or From Mainchain?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not clear enough.

Please modify.

Split in two main part -> what is part of MainChain, what is part of Sovereign.

Besides the ESDT-Safe and Token-Handler contracts (where is token handler described and what's it's purpose) I do not know what the other symbols represent. The first user is Alice who is sending to her on the same chain or is it a differnet chain? etc etc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not clear enough.

@andreiblt1304 andreiblt1304 changed the base branch from main to development January 15, 2025 08:04
@andreiblt1304 andreiblt1304 changed the base branch from development to main January 15, 2025 08:08
@andreiblt1304 andreiblt1304 self-assigned this Jan 15, 2025
@andreiblt1304 andreiblt1304 changed the base branch from main to development January 16, 2025 07:40
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
axenteoctavian
axenteoctavian previously approved these changes Jan 17, 2025
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
Signed-off-by: Andrei Baltariu <andreibaltariu1304@gmail.com>
CostinCarabas
CostinCarabas previously approved these changes Mar 31, 2025
@andreiblt1304 andreiblt1304 merged commit fea654e into development Apr 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants