Development #1079
Merged
Development #1079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et-owner.pem"` When following the tutorial, I wasn't able to deploy the sc because the program was panicking when not finding the "/wallet-owner.pem". The fix was adding the absolute path, completing with the missing directories above "/ping-pong/wallet/wallet-owner.pem". I added a comment at line 178, suggesting this fix for devs following the tutorial.
Added a paragraph after «(...) by automated processes.» and before «The **nodes** (...)». Better to distinguish the entities and easier to read.
Add paragraph before «The **nodes** (...)»
Add comment related to `Wallet::from_pem_file("/ping-pong/wallet/wall…
CiprianDraghici
previously approved these changes
Mar 6, 2025
andreibancioiu
previously approved these changes
Mar 6, 2025
…k-js-v-14 Add v14 Cookbook for sdk-js
danielailie
dismissed stale reviews from andreibancioiu and CiprianDraghici
via
5a59458
Update docs for relayed transactions
danielailie
approved these changes
Mar 18, 2025
CiprianDraghici
approved these changes
Mar 18, 2025
andreibancioiu
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the pull request (what is new / what has changed)
Did you test the changes locally ?
Which category (categories) does this pull request belong to?