Breaking change: adjustements to transaction awaitening and completion, transaction watcher #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Adjust transactionWatcher. WIP.
…onOnNetwork.getStatus() should be used instead.
andreibancioiu
changed the title
andreibancioiu
changed the title
ccorcoveanu
previously approved these changes
Apr 4, 2022
claudiu725
suggested changes
Apr 4, 2022
Co-authored-by: Claudiu-Marcel Bruda <claudiu725@yahoo.com>
claudiu725
approved these changes
Apr 4, 2022
ccorcoveanu
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
transaction.awaitExecuted(),transaction.awaitPending().TransactionWatchershould be used directly, instead.TransactionWatcher. The constructor does not expect a transaction hash anymore, but the functionsawait*do.TransactionWatcher:awaitCompleted(),awaitAllEvents(),awaitAnyEvent()etc.Transaction.status(the one onTransactionOnNetworkshould be read instead).Transaction.getAsOnNetwork()does not wait for notarization / completion anymore. One should explicitly use the transaction watcher, when needed.