Breaking change: simplify network config / improve design - not a singleton anymore. #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccorcoveanu
reviewed
Apr 4, 2022
src/transaction.ts
Outdated
|
|
||
| setChainID(chainID: ChainID) { | ||
| this.chainID = chainID; | ||
| this.doAfterPropertySetter(); |
Contributor
There was a problem hiding this comment.
I think this is a side effect that the user does not expect - I remember debugging with @arhtudormorar quite a lot what was the problem with a transaction, and it was missing the signature after setting some properties.
If a user changes something on a signed transaction, the signature will be invalid even if it's set or if it's empty, so I don't know if we should force the reset for them
Contributor
Author
There was a problem hiding this comment.
Fixed, removed doAfterPropertySetter().
claudiu725
approved these changes
Apr 4, 2022
ccorcoveanu
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetworkConfig.getDefault()andNetworkConfig.sync(). Instead, one should uselet networkConfig = await provider.getNetworkConfig().Transactionnow requireschainID, as well.Interaction.withChainID()- must be used before callingbuildTransaction().